Skip to content

[WIP] v1.0 fixes cherry pick #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Aug 20, 2020

The following PR cherry picks the following fixes:

To be confirmed if it's required:

@filipecosta90 filipecosta90 changed the base branch from master to 1.0 August 20, 2020 20:58
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #448 into 1.0 will increase coverage by 0.40%.
The diff coverage is 90.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.0     #448      +/-   ##
==========================================
+ Coverage   72.60%   73.00%   +0.40%     
==========================================
  Files          21       21              
  Lines        4381     4420      +39     
==========================================
+ Hits         3181     3227      +46     
+ Misses       1200     1193       -7     
Impacted Files Coverage Δ
src/script.c 68.12% <83.33%> (+4.41%) ⬆️
src/redisai.c 80.00% <89.74%> (+1.11%) ⬆️
src/dag.c 89.11% <100.00%> (+0.85%) ⬆️
src/model.c 70.36% <100.00%> (+0.67%) ⬆️
src/run_info.c 85.97% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3e6b9...9aa7d70. Read the comment docs.

filipecosta90 and others added 6 commits August 20, 2020 22:33
…I.DAGRUN_RO, AI.MODELRUN, AI.SCRIPTRUN ) (#438)

* [wip] wip on fixing the commands being flagged as getkeys-api during the registration. ( AI.MODELRUN, AI.SCRIPTRUN, AI.DAGRUN, AI.DAGRUN_RO )

* [add] pytorch oss cluster tests passing

* [add] TensorFlow lite tests passing on oss cluster

* [add] ONNX tests passing on oss cluster

* [add] TensorFlow tests passing on oss cluster

* [wip] wip on dag

* [add] DAG tests passing on oss cluster

* [add] enabling oss cluster tests on CI

* [add] bumping rmbuilder version from 6.0.1 to 6.0.5 on circleci

* [fix] fixed potential invalid mem accesses on RedisAI_DagRunSyntaxParser, RAI_parseDAGPersistArgs

* [fix] fixed RAI_FreeDagOp wrongfully calling RedisModule_Free on dagOp->inkeys, dagOp->outkeys

* [fix] fixed dictKey allocation on RAI_parseDAGLoadArgs

* [add] alter Sanitizer tests to accommodate keys on the same slot.

* [add] extracted the methods to respond to RedisModule_IsKeysPositionRequest() from main code of dagrun,modelrun, and scriptrun to specific methods

* [fix] Fixes per PR review

* [fix] fixes per PR review

* [fix] fix per CI ascii conversion error on test_dagro_modelrun_financialNet_no_writes_multiple_modelruns
* Fixed platforms build problem

* Build: updated Redis versions

* Build: another Redis version update
* [add] updated support email and Orobix to Tensorwork on ramp file

Co-authored-by: Sherin Thomas <[email protected]>
@filipecosta90
Copy link
Collaborator Author

Closing this one, in favor of a new with the ordered commits cherry picked

@filipecosta90 filipecosta90 deleted the 1.0-fixes-cherry-pick branch November 23, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants